docs: clarify contract ID placeholders and env vars in deployments.md#673
Merged
Merged
Conversation
Closes AnnabelJoe#522 - Replace ambiguous '_(set after first deploy)_' text with explicit <PLACEHOLDER> tokens so maintainers know what to fill in. - Add required env var blocks for both testnet and mainnet. - Add placeholder convention note at the top of the file. - Link update steps to DEPLOYMENT.md for the full deploy guide.
|
@ZainabJanee Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #522
Rewrites
docs/deployments.mdso maintainers clearly know which values are placeholders and how to fill them in.Changes
_(set after first deploy)_with explicit<PLACEHOLDER>tokens (e.g.<TESTNET_ENERGY_TOKEN_ID>) that cannot be mistaken for real contract IDs..env.example.docs/DEPLOYMENT.md.Tested
Documentation-only change; no code modified.